test in app builder encouraged in server card by ignaciojimenezr · Pull Request #1666 · MCPJam/inspector

ignaciojimenezr · 2026-03-25T04:30:59Z

Screen.Recording.2026-03-24.at.10.33.32.PM.mov

railway-app · 2026-03-25T04:31:07Z

🚅 Environment inspector-pr-1666 in triumphant-alignment has no services deployed.

1 service not affected by this PR

mcp-inspector

chelojimenez · 2026-03-25T04:31:14Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

coderabbitai · 2026-03-25T05:56:48Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 66cae5cd-9e02-44f7-b9fc-1c602aa2fc1a

📥 Commits

Reviewing files that changed from the base of the PR and between 0069520 and 6d2b333.

📒 Files selected for processing (4)

mcpjam-inspector/client/src/components/connection/shared/AuthenticationSection.tsx
mcpjam-inspector/client/src/components/mcp-sidebar.tsx
mcpjam-inspector/client/src/components/sidebar/nav-main.tsx
mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx

✅ Files skipped from review due to trivial changes (1)

mcpjam-inspector/client/src/components/connection/shared/AuthenticationSection.tsx

🚧 Files skipped from review as they are similar to previous changes (2)

mcpjam-inspector/client/src/hooks/tests/use-ui-app-servers.test.tsx
mcpjam-inspector/client/src/components/mcp-sidebar.tsx

Walkthrough

This PR introduces a new hook, useUiAppServers, which asynchronously fetches per-server tool metadata with a 5s per-server timeout to derive appServerNames and resolvedServerNames. The sidebar App Builder "bubble" feature and its related props/state were removed. ServerConnectionCard gained onOpenAppBuilder and isUiCapabilityResolved props and a conditional "Test in app builder" action. ServersTab and App were updated to pass an onOpenAppBuilder callback that selects a server and navigates to the app-builder tab. Tests for the UI-capability resolution behavior were added.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx (1)
25-42: Migrate to the shared createServer() factory from client/src/test/factories.ts.

The test defines a local createServer() that duplicates the shared factory. Migrate to the shared factory and pass name as an override property rather than a positional parameter. Alternatively, use createConnectedServer() for test-specific defaults. This ensures fixture consistency across the codebase.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx`
around lines 25 - 42, Replace the local createServer factory with the shared
factory: remove the local function createServer and import the shared
createServer from the test factories file, calling it with an overrides object
that includes name (e.g. createServer({ name, ...otherOverrides })) instead of a
positional name arg; for tests that need the connected defaults use the shared
createConnectedServer helper (or pass connection-related overrides) so fixtures
remain consistent with ServerWithName and existing test factories.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx`:
- Around line 25-42: Replace the local createServer factory with the shared
factory: remove the local function createServer and import the shared
createServer from the test factories file, calling it with an overrides object
that includes name (e.g. createServer({ name, ...otherOverrides })) instead of a
positional name arg; for tests that need the connected defaults use the shared
createConnectedServer helper (or pass connection-related overrides) so fixtures
remain consistent with ServerWithName and existing test factories.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df8211c0-6c1f-4f59-8673-8790fe69e23b

📥 Commits

Reviewing files that changed from the base of the PR and between 74bc308 and 0069520.

📒 Files selected for processing (8)

mcpjam-inspector/client/src/App.tsx
mcpjam-inspector/client/src/components/ServersTab.tsx
mcpjam-inspector/client/src/components/connection/ServerConnectionCard.tsx
mcpjam-inspector/client/src/components/connection/__tests__/ServerConnectionCard.test.tsx
mcpjam-inspector/client/src/components/mcp-sidebar.tsx
mcpjam-inspector/client/src/components/sidebar/nav-main.tsx
mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx
mcpjam-inspector/client/src/hooks/use-ui-app-servers.ts

prathmeshpatel · 2026-03-25T07:59:27Z

mcpjam-inspector/client/src/components/connection/ServerConnectionCard.tsx

+                  className="inline-flex items-center gap-1.5 rounded-full border border-border/70 bg-muted/30 px-2 py-0.5 text-[11px] text-foreground transition-colors hover:bg-accent/60 cursor-pointer"
+                >
+                  <Rocket className="h-3 w-3" />
+                  <span>Test in app builder</span>


Suggested change

<span>Test in app builder</span>

<span>Test in App Builder</span>

test in app builder encouraged in server card

b137ea0

ignaciojimenezr added 2 commits March 24, 2026 22:32

hanging ui detection case + test case

79b4506

lint + test case

0069520

ignaciojimenezr marked this pull request as ready for review March 25, 2026 05:48

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request labels Mar 25, 2026

ignaciojimenezr and others added 2 commits March 24, 2026 22:53

Merge origin/main into action-based-cta

1e32a04

style: auto-fix prettier formatting

2fc7682

coderabbitai bot reviewed Mar 25, 2026

View reviewed changes

ignaciojimenezr and others added 2 commits March 24, 2026 22:57

trigger CI

6d2b333

Merge branch 'main' into action-based-cta

9cbed6a

ignaciojimenezr requested review from chelojimenez and prathmeshpatel and removed request for prathmeshpatel March 25, 2026 06:24

prathmeshpatel reviewed Mar 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test in app builder encouraged in server card#1666

test in app builder encouraged in server card#1666
ignaciojimenezr wants to merge 7 commits intomainfrom
action-based-cta

ignaciojimenezr commented Mar 25, 2026 •

edited

Loading

Uh oh!

railway-app bot commented Mar 25, 2026

Uh oh!

chelojimenez commented Mar 25, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

prathmeshpatel Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<span>Test in app builder</span>
	<span>Test in App Builder</span>

Uh oh!

Conversation

ignaciojimenezr commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

railway-app bot commented Mar 25, 2026

Uh oh!

chelojimenez commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

coderabbitai bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

prathmeshpatel Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ignaciojimenezr commented Mar 25, 2026 •

edited

Loading

chelojimenez commented Mar 25, 2026 •

edited

Loading

coderabbitai bot commented Mar 25, 2026 •

edited

Loading